Paths

Table of Contentst

Diffusion Anari 08ff791afcf4

Color Class
Concern Raised08ff791afcf4
Actions

Description

Color Class

Summary: A class that represents colors in Anari and converts them in different formats

Test Plan: run color test suite (tbd)

Reviewers: jcmcdonald, gacmix, imirzali

Reviewed By: jcmcdonald, gacmix, imirzali

Subscribers: imirzali, mahussain, mduminer

Tags: Anari [Project], IMF [Team], Programming [Dept]

Maniphest Tasks: T1247

Differential Revision: https://phabricator.mousepawmedia.net/D248

Details

Auditors

• imirzali

Provenance

mahussain	Authored on Apr 11 2020, 1:29 AM
mahussain	Pushed on Apr 11 2020, 7:19 AM

Reviewer

jcmcdonald

Differential Revision

D248: Color Class

Parents

rA604890d7d0de: Fix build system - T1303

Branches

Unknown

Tags

Unknown

Tasks

T1247: ARGB Colors

Event Timeline

mahussain committed rA08ff791afcf4: Color Class (authored by mahussain).Apr 11 2020, 7:18 AM

mahussain added an edge: D248: Color Class.

mahussain added a task: T1247: ARGB Colors.

Restricted Application completed building Restricted Buildable.Apr 11 2020, 7:20 AM

• imirzali added an auditor: • imirzali.May 24 2020, 1:20 PM

• imirzali added a subscriber: • imirzali.

This commit now requires audit.May 24 2020, 1:20 PM

The register_test seem to be wrong, I'm not sure if this would cause a leak or some other weird behavior.

/anari-source/src/colors_test.cpp
5–17	Shouldn't the calls have `()` like calling a function? For example, it should be: `register_test("A-tB0209", new Test_CMYKConstructor());`

This commit now has outstanding concerns.May 24 2020, 1:23 PM

jcmcdonald added a subscriber: jcmcdonald.May 24 2020, 2:27 PM

jcmcdonald added inline comments.

/anari-source/src/colors_test.cpp
5–17	Actually, no. As long as you're using the default constructor (no arguments), it won't matter either way AFAIR.

Changes (39)

Path

Size

.vscode/

settings.json

anari-source/

CMakeLists.txt

include/

anari/

src/

anari-tester/

docs/

source/

_themes/

sphinx_rtd_theme/

static/

css/

fonts/

Inconsolata-Regular.ttf

Lato-Bold.ttf

Lato-Regular.ttf

fontawesome-webfont.eot

fontawesome-webfont.svg

fontawesome-webfont.ttf

fontawesome-webfont.woff

fontawesome-webfont.woff2

js/

rA08ff791afcf4

View Options

.vscode/settings.json

View Options

anari-source/CMakeLists.txt

View Options

anari-source/include/anari/colors.hpp

View Options

anari-source/include/anari/colors_test.hpp

View Options

anari-source/include/anari/config.hpp

View Options

anari-source/include/anari/demo.hpp

View Options

anari-source/include/anari/hardcoded.hpp

View Options

anari-source/include/anari/math.hpp

View Options

anari-source/include/anari/window.hpp

View Options

anari-source/src/colors.cpp

View Options

anari-source/src/colors_test.cpp

View Options

anari-source/src/demo.cpp

View Options

anari-source/src/math.cpp

View Options

anari-tester/main.cpp

View Options

docs/source/_themes/sphinx_rtd_theme/init.py

View Options

docs/source/_themes/sphinx_rtd_theme/breadcrumbs.html

View Options

docs/source/_themes/sphinx_rtd_theme/footer.html

View Options

docs/source/_themes/sphinx_rtd_theme/layout.html

View Options

docs/source/_themes/sphinx_rtd_theme/searchbox.html

View Options

docs/source/_themes/sphinx_rtd_theme/static/css/badge_only.css

View Options

docs/source/_themes/sphinx_rtd_theme/static/css/badge_only.css.map

View Options

docs/source/_themes/sphinx_rtd_theme/static/css/theme.css

View Options

docs/source/_themes/sphinx_rtd_theme/static/css/theme.css.map

View Options

docs/source/_themes/sphinx_rtd_theme/static/fonts/FontAwesome.otf

View Options

docs/source/_themes/sphinx_rtd_theme/static/fonts/Inconsolata-Bold.ttf

View Options

docs/source/_themes/sphinx_rtd_theme/static/fonts/Inconsolata-Regular.ttf

View Options

docs/source/_themes/sphinx_rtd_theme/static/fonts/Lato-Bold.ttf

View Options

docs/source/_themes/sphinx_rtd_theme/static/fonts/Lato-Regular.ttf

View Options

docs/source/_themes/sphinx_rtd_theme/static/fonts/fontawesome-webfont.eot

View Options

docs/source/_themes/sphinx_rtd_theme/static/fonts/fontawesome-webfont.svg

View Options

docs/source/_themes/sphinx_rtd_theme/static/fonts/fontawesome-webfont.ttf

View Options

docs/source/_themes/sphinx_rtd_theme/static/fonts/fontawesome-webfont.woff

View Options

docs/source/_themes/sphinx_rtd_theme/static/fonts/fontawesome-webfont.woff2

View Options

docs/source/_themes/sphinx_rtd_theme/static/js/theme.js

View Options

docs/source/_themes/sphinx_rtd_theme/theme.conf

View Options

docs/source/_themes/sphinx_rtd_theme/versions.html

View Options

docs/source/attributes/colors.rst

View Options

Color ClassConcern Raised08ff791afcf4Actions

Description

Details

Event Timeline

Changes (39)

rA08ff791afcf4

.vscode/settings.json

anari-source/CMakeLists.txt

anari-source/include/anari/colors.hpp

anari-source/include/anari/colors_test.hpp

anari-source/include/anari/config.hpp

anari-source/include/anari/demo.hpp

anari-source/include/anari/hardcoded.hpp

anari-source/include/anari/math.hpp

anari-source/include/anari/window.hpp

anari-source/src/colors.cpp

anari-source/src/colors_test.cpp

anari-source/src/demo.cpp

anari-source/src/math.cpp

anari-tester/main.cpp

docs/source/_themes/sphinx_rtd_theme/__init__.py

docs/source/_themes/sphinx_rtd_theme/breadcrumbs.html

docs/source/_themes/sphinx_rtd_theme/footer.html

docs/source/_themes/sphinx_rtd_theme/layout.html

docs/source/_themes/sphinx_rtd_theme/searchbox.html

docs/source/_themes/sphinx_rtd_theme/static/css/badge_only.css

docs/source/_themes/sphinx_rtd_theme/static/css/badge_only.css.map

docs/source/_themes/sphinx_rtd_theme/static/css/theme.css

docs/source/_themes/sphinx_rtd_theme/static/css/theme.css.map

docs/source/_themes/sphinx_rtd_theme/static/fonts/FontAwesome.otf

docs/source/_themes/sphinx_rtd_theme/static/fonts/Inconsolata-Bold.ttf

docs/source/_themes/sphinx_rtd_theme/static/fonts/Inconsolata-Regular.ttf

docs/source/_themes/sphinx_rtd_theme/static/fonts/Lato-Bold.ttf

docs/source/_themes/sphinx_rtd_theme/static/fonts/Lato-Regular.ttf

docs/source/_themes/sphinx_rtd_theme/static/fonts/fontawesome-webfont.eot

docs/source/_themes/sphinx_rtd_theme/static/fonts/fontawesome-webfont.svg

docs/source/_themes/sphinx_rtd_theme/static/fonts/fontawesome-webfont.ttf

docs/source/_themes/sphinx_rtd_theme/static/fonts/fontawesome-webfont.woff

docs/source/_themes/sphinx_rtd_theme/static/fonts/fontawesome-webfont.woff2

docs/source/_themes/sphinx_rtd_theme/static/js/theme.js

docs/source/_themes/sphinx_rtd_theme/theme.conf

docs/source/_themes/sphinx_rtd_theme/versions.html

docs/source/attributes/colors.rst

docs/source/index.rst

Color Class
Concern Raised08ff791afcf4
Actions

docs/source/_themes/sphinx_rtd_theme/init.py