• added windows instructions

• added windows instructions

Nice! Only a couple minor things now. Almost there!

• Changed location of instructions
• Deleted duplicates
• added windows instructions

Got it, I will move the instructions to the appropriate places. Thanks for the correction.

• Added aranistt instructions

In D464#15598, @jcmcdonald wrote:

Excellent.

However, I do believe you also need the arcanist-clang-format-linter package?

Besides that, assuming nothing else is needed, this should be good to go.

However, I do believe you also need the arcanist-clang-format-linter package?

• Changed location of instrcution

• Changed location of instrcution

• Changed location of instrcution

Technically, this is covered with your documentation changes.

I realized we also need to have the arclint file setup to have it work properly on cpp and hpp files. I will make sure to do that for all the necessary repositories.

In D443#15154, @jcmcdonald wrote:

Huh. I just figured something out that would simplify everything. I thought it was strange that there was an arcanist-clang-format-linter package on Ubuntu, but that we couldn't seem to use it. On that page for the Debian package, I found the link to the repository: https://github.com/pwithnall/morefas-phabricator

That suggested the ability to install globally, instead of with git submodule.

I checked one of the repos where I hadn't yet installed the submodule, and arc lint --everything failed with the error message.

Then I adjusted the .arcconfig file in one of the repos where I hadn't yet installed the submodule.

{
	"phabricator.uri" : "https://phab.mousepawmedia.com",
	"repository.callsign" : "I",
	"load" : [
		".arclibs/cppcheck",
		"clang-format-linter"
	]
}

Running arc lint --everything ran clang-format-linter that time. No submodule needed!

Now, that said, for someone who is not on an Ubuntu-based OS, they'll need to clone the morefas-phabricator repository to their system manually. Use locate arcanist to find the path where arcanist is installed (e.g. /usr/share), navigate to that directory, and then run...

cd /usr/share   # or whatever path given by 'where arcanist'
sudo git clone https://github.com/pwithnall/morefas-phabricator.git clang-format-linter

That should make it available to Arcanist as well, according to the README for that repo.

Sorry I couldn't find this info before. The above will be a more user-friendly way of installing clang-format-linter, instead of having to remember to run git submodule each time. (It will be hard for many interns and contributors to understand that command!)

Huh. I just figured something out that would simplify everything. I thought it was strange that there was an arcanist-clang-format-linter package on Ubuntu, but that we couldn't seem to use it. On that page for the Debian package, I found the link to the repository: https://github.com/pwithnall/morefas-phabricator

That will need to be documented somehow too. It's an additional step that will be very confusing to future interns if they don't know about it.

In D443#15142, @jcmcdonald wrote:

I'm not sure. Do you need to run this on each repository?

I'm not sure. Do you need to run this on each repository?

In D443#15132, @jcmcdonald wrote:

These steps will need to be added to the Git and Arcanist document.

These steps will need to be added to the Git and Arcanist document.

Ammended changes

Fixed indentation and other error

When modifying documentation, make sure you build it and check it locally on your system, and address any warnings there might be.