• refactor: address linter issues

• refactor: add commented code

In D552#17838, @galmonte wrote:

@vperea have you tried to declare the varialble as int instead of size_t. If I'm not mistaken size_t can't storage any negative number.

• refactor: address linter issues

• fix: change the outer loop limit due linter issues

Hello @galmonte I have been working on this but I couldn't find a better solution and it gives me a linter issue due to the equal to 0 in the outer loop but if I omit it then it gives me negative numbers in case there is no match . I would appreciate some orientation here because I'm not seeing what is wrong in my approach 😅

• refactor: adress linter issues

Hello @galmonte @jcmcdonald I would appreciate some feedback :)

• refractor: address linter issues

• refractor: address linter issues
• refractor: fix test comment in rfind()

• refractor: correct some typos & some tests
• test: add all tests to main.cpp to check documentation results

In D537#17376, @galmonte wrote:

@vperea, I will review it tonight.

Hello @jcmcdonald @galmonte I would appreciate some feedback :)

• refractor: address linter issues

• refractor: adress linter issues
• refractor: correct a typo in return comment

• feat: add find_first_of function
• test: add tests for find_first_of()
• refractor: switch the loop iterator to ++i
• refractor: address linter issues in main

• refractor: switch the loop iterator to ++i
• refractor: address linter issues in main

• refractor: address linter issues

In D527#17184, @jcmcdonald wrote:

Ahh, tracking with you now. This is abandoned. So, on the bottom of the Differential you want to abandon, and go to Add Action... → Abandon Revision.

• test: add tests for find_last_not_of()
• feat: add find_first_not of() & find_last_not_of()
• feat: add ternary operator to outside loop
• feat: add more tests.
• feat: complete function & improve comments.
• refractor: address format linter issues
• refractor: improve the function with a reverse loop
• refractor: address format suggestions
• refractor: address unsignedPositive warning
• refractor: try to solve unsignedPositive issue
• refractor: address unsignedPositive warning
• test: add a test & correct some others
• refractor: correct the condition for i start value
• refractor: address format issues
• test: remove a test causing a pos out range output
• refractor: improve function
• refractor: fix rebase conflicts
• test: add emoji and str tests
• feat: add overload func & change condition pointer
• refractor: address linter issues

In D527#17026, @galmonte wrote:

Good job, Vanesa. I see that you have improved your CPP skills.

I'm trying to deal with the unsignedPositive issue, the problem I think is that the loop finishes when 'i' is 0 so when the last character not matching is in the position 0 (letter t in this case) it does not detect it.

• refractor: address format linter issues
• refractor: improve the function with a reverse loop. Starting from the end of the string reduces the number of iterations and there is no need for store the i value in a variable.

In T1549#40318, @galmonte wrote:

If you landed your Onestring::find_last_not_of differential, you can close this subtask and create a new subtask for Onestring::find_last_not_of().

• refractor: address linter format issues
• refractor: correct a misunderstood word

In D524#16931, @jcmcdonald wrote:

Great work! I only have one remaining comment.

@galmonte @jcmcdonald I've changed the comments and include find(). I would appreciate some feedback :)

In T1549#40144, @jcmcdonald wrote:

Good job. However, since you're part of the actual project, you can use the User Story next time.

Please do edit this task and set Priority, Gravity, Distance, Friction, and Relativity. These are defined here if you need a refresher: https://standards.mousepawmedia.com/en/latest/qtm.html

In D524#16861, @galmonte wrote:

I can see that you did a very good job here, Vanesa. I'm looking forward to seeing more of your work. 😄

• refractor: change to prefix notation at loops Also, fix a typo at std::out_of_range output

• refractor: address variable scope linter issue

• refractor: address linter issues