• Feat: Added the list command to list registered commands.

• Feat: Added 'list' function to list all the registered functions available.

• Docs: Updated the blueshell.rst file for usage on Blueshell.

• Style: Just removed some old comments that I missed.

• Style: Changed for loop to transform because linter suggested it. Made various changes to the code to clean things up. Fixed issue with 'help <command name>' printing the container out in the wrong order.

• Feat: Finished cmd_map header to replace map<pair<pair>>. Added the ability to use 'history' with a command search (eg. history test_attempt' would list only any history with test_attempt, and no others.

In D545#17695, @wdede wrote:

In D545#17625, @jdtolmie wrote:

@wdede
I have a question about what you think is best. I added it to the comment you made.

The function would be written once and called as many times as needed. Basically, it is not really a repetition as the argument will be different every time.
Second, in my opinion, here there is no "need" to pass by reference, you can just pass the objects by value, I avoid messing with pointers and referenced values when not necessary. But feel free to experiment.

• Trying to fix linter error.

• Feat: Added the ability to use double tab at the end of the string, and not only the first word. Added a few other features.

• Linter issue still

• Perf: Trying to fix linter issue of unused variable, even though it is used.

• Linter fixes

• Perf: Added cmd_map struct to seperate header, as the cppcheck linter was complaining about some un-used variable, even though it was used.

• Style: Removed old code commented out after change to map<string, cmd_map>.

• Lint changed these.

• Perf: Removed std::map<std::string, std::pair<std::pair<std::pair<std::string, std::string>, _register>, int>> as it was confusing trying to figure out how to access it (is it second.second.first, or second.second.second?). Replaced with struct, and made a map<string, struct_name>. Changed the other files to work with the new struct.
• Added file to register the default commands for the shell.

@wdede
I have a question about what you think is best. I added it to the comment you made.

• Feat: Fixed the help menu to display the description nicely. It now prints the command on the left, and word wraps the description.

• Removed cout showing the values of various bools for checking for open/closed option strings.

• Fixed linter warning.

• Not sure what changes were done. Perhaps a linter change.

• Doc: Created blueshell.rst file to give description on how to use Blueshell. Also added option to name the shell a custom name for the user inheriting the shell.

• Feat: Added the ability to name the shell when calling the constructor. Defaults to Blueshell if argument is left blank.
• Changed main.cpp to use Blueshell constructor and not testregister constructor. Just for testing purposes.

• Removed the rest of commented code as per Jason McDonald.

• Removed codeblocks file

• Probably lint changes.

• Feat: Added option to add \ to the string if \ was passed as an option. Cleaned up some commented out code.

• Perf: Changed location of where the command was removed from the list of options. Removing from front of deque where the options are stored, rather than removing beforehand. Removed the '\' from the strings if quotes are used..

• Style: Changes made by arc diff.

• Still trying to fix issue with clang-format-linter.

• Style: clang-format-linter changes to the code, and I removed link to the clang-format-linter folder from .arclibs.
• Perf: Changed std::find to string::erase to remove ! from the command if recalling a previous command.
• Fix: Forgot to remove clang-format-linter from .arcconfig file.

I think I got everything fixed you wanted. I will try the clang fix again, but the last few times I tried, it failed. I must be messing up something.

• Feat: Added deletion of character under the cursor. Fixed some bugs.
• Added deletechar.cpp

• Feat: Added inserting and erasing characters from the command when using the left/right arrow keys. Fixed a couple of bugs as well.

• Nothing changed, but for some reason it says it did. Maybe it will show up now :)

• Ran arc diff. Fixed some of the warnings found.

I did not run it, but from what I saw it looks good. Just one comment on "" vs std::string(). Mind you, being able to read it and thinking you understand it, and being able to fully understand are different :)

Sure...

Issue with main.cpp.

Trying to find out why this will not land, and even creating a new branch pulls in old commits that are not mine.

• Added testregister.hpp for testing purposes.

• Feat: Added 'history' command, and bang history command.

• Feat: Added 'history' command, and bang history command.

• Feat: Added tab functionality to fill in partial typed commands with any that match. If multiple are available, it will print them to the terminal, and fill in as much as matches all of the commands.

• Feat: Made a lot of changes. Moved most functions into their own file. Pressing tab mostly works for listing stored functions, and if a partial command was typed, it will search for any starting with that. Fixed some issues with arrow keypress, and added a call to tab if using arrows, then pressing tab.

There is one or more things I need to fix on up/down key press before review.

• Fix: Fixed issue with up/down arrow press having to be pressed twice when pressing opposite arrow press (having to press down twice to start traversing again etc). Added comments to that part of the code.

Planning on working on this again soon. The lint warnings I do not know how to fix, as I need this code as is (as far as I can tell). If I can find a solution to solving this issue, I will fix it then.

Trying to find lint errors

• feat: Got up/down arrow press traversing the 'previous_command' vector. Pressing 'enter' will call up the command. One issue is that if part way through the vector, you have to press the down arrow twice before if starts down again. It calls up the print_line function with the same vector element. Would like to find a way to fix that.

I have not addressed the errors because I was not done working on it. I was just going to bed and thought I should commit in case something happened overnight. As for the testregister files, do you mind me leaving them where they are, as when I am done with them I can clean them up at that time? They are just there so I know which ones to clean up when needed. It saves me missing something when I am done, and looking for my test files.

Running linter

• Added mostly functional up, down, and tab key presses.

• Removed an unused vector

I made some changes as requested, and commented on some that I need clarification on.

• Removed an unused vector

• feat: Added std::string parameter to the function pointer and commands that are called, in order to allow options to be sent if needed

• feat: Added tests from 'register' to the available commands after registering them. Changed unordered_map to a map, to make it sorted for displaying it better
• feat: Added 'list'/'help' to the register function to show what tests are available if required again. It shows the tests when 'register' is first run

• Removed some temp files from codeblocks
• Moved available_commands map to public, so it could be accessed by the derived classes.

• Comments added to files, and changed from std::map to std::unordered_map.

• Comments added to files, and changed from std::map to std::unordered_map.

I made the changes that lint wanted me to, and corrected a few things that I thought I had working. I will create a subtask, but I realised that if you 'add test', and then 'add test' again, it will add 'test' twice to the root. I was going to fix it, but thought if I am giving this to Jaime, that he could work on it. Let me know if you want me to do it.

• Made some changes I thought I already did. Fixed a few things Jason wanted done

• Made some changes I thought I already did. Fixed a few things Jason wanted done

• Made some changes I thought I already did. Fixed a few things Jason wanted done

• Created a map<string, function ptr>. Tested by adding 'help' and 'clear'.

• Made change to add_child to put a new Node, not a shared_ptr<Node>

• Fixed segmentation faults. Fixed issues with 'find_node' and 'load' not adding all of the elements of the vector passed to them.

Here is the full code I am working with, in order to test it: https://phab.mousepawmedia.com/P61

• Changed find_node and load to take vector<string>, not a string. Fixed issue with various segmentation faults, and now 'find' should work properly, as it was finding a node without looking up the tree structure

• Total rewrite of coordinator.hpp and .cpp. Based off of tree Jason C. McDonald wrote in python.

• Made changes to coordinator.cpp and hpp to create child nodes in the class

• Changed recommended fixes from lint when running arc diff.

• Complete redo of Coordinator cpp and hpp file