Page MenuHomePhabricator

jcmcdonald (Jason C. McDonald)
CEO, Lead DeveloperAdministrator

Projects (51)

User Details

Office Hours
Mon-Fri 11 AM - 5 PM (US/Pacific)
Time Zone
US/Central
Location
Minnesota, USA
School
North Idaho College (Alumni)
DEV
https://dev.to/codemouse92
Github Account
https://github.com/codemouse92
IRC Nick
CodeMouse92
Stack Overflow
http://stackoverflow.com/users/472647/codemouse92
Operating System
Ubuntu (Pop_OS!) MATE 19.10
Less Serious Stuff
Alternative Species
Rat
Favorite Color
Ummm...I actually don't know.
Listening To...
Red, Sergey Cheremisinov, Disciple, Tobymac, Out of the Gray, Wolves at the Gate
Reading...
Agatha Christie, Tony Hillerman, Lucy Maud Montgomery, G.K. Chesterton
Watching...
My Little Pony: FiM, Carmen Sandiego, Puffin Rock, Doctor Who
Working on...
"Dead Simple Python" book (No Starch Press)
Coffee Order
Caramel Macchiato
Pizza Order
Avocado, Chicken, Bacon, Tomato, Pesto
Other Vehicle
TARDIS
Anoid High Score
120/120 w/ 2 deaths; 132/132 with 3 deaths
Roles
Administrator
User Since
Jan 1 2015, 5:20 PM (403 w, 6 d)

Author | Hacker | Speaker | Time Lord

Recent Activity

Today

jcmcdonald accepted D536: Changed colour formatting for commands in help.cpp..
Thu, Sep 29, 3:26 AM · Programming [Dept], IOSqueak [Project]

Yesterday

jcmcdonald requested changes to D536: Changed colour formatting for commands in help.cpp..

You'll want to remove commented out code completely in most cases. The only time you'd keep is if future developers need to be able to comment/uncomment it to turn on/off some sort of debugging statement.

Wed, Sep 28, 4:29 AM · Programming [Dept], IOSqueak [Project]

Sat, Sep 24

jcmcdonald requested changes to D536: Changed colour formatting for commands in help.cpp..

This is looking pretty good! Minor notes, mostly unrelated to the code itself.

Sat, Sep 24, 11:34 AM · Programming [Dept], IOSqueak [Project]
jcmcdonald committed rDEVDOCd05bf6205419: fix: update Arcanist repository URL (authored by jcmcdonald).
fix: update Arcanist repository URL
Sat, Sep 24, 11:24 AM

Tue, Sep 6

jcmcdonald accepted D529: feat: conestring::rfind().
Tue, Sep 6, 5:40 PM
jcmcdonald requested changes to D529: feat: conestring::rfind().
Tue, Sep 6, 5:30 PM

Sat, Sep 3

jcmcdonald added a comment to D345: static layer basic functions and tests.
In D345#17258, @wdede wrote:

@wdede You'll want to commandeer this revision from the Add Action... menu at the bottom.

The option disappeared for some reason.

Sat, Sep 3, 4:25 PM · Programming [Dept], IMF [Team], Anari [Project]
jcmcdonald accepted rSef1f5075ec01: fixes the string off by one errors.
Sat, Sep 3, 4:20 PM
jcmcdonald accepted D529: feat: conestring::rfind().
Sat, Sep 3, 4:19 PM

Wed, Aug 31

jcmcdonald accepted D345: static layer basic functions and tests.
Wed, Aug 31, 5:29 PM · Programming [Dept], IMF [Team], Anari [Project]
jcmcdonald accepted D468: fixes the string off by one errors.
Wed, Aug 31, 4:22 PM · SIMPLEXpress [Project], Programming [Dept]

Tue, Aug 30

jcmcdonald accepted D534: Onestring: find_first_not_of update.
Tue, Aug 30, 4:05 PM

Aug 24 2022

jcmcdonald accepted D533: Onestring: find_last_not_of() improved.
Aug 24 2022, 5:07 PM
jcmcdonald added a comment to D527: Onestring: find_last_not_of().

Ahh, tracking with you now. This is abandoned. So, on the bottom of the Differential you want to abandon, and go to Add Action...Abandon Revision.

Aug 24 2022, 5:07 PM · Programming [Dept], Onestring [Project]
jcmcdonald accepted D527: Onestring: find_last_not_of().

This is excellent, well done.

Aug 24 2022, 5:04 PM · Programming [Dept], Onestring [Project]

Aug 15 2022

jcmcdonald accepted D528: refactor: changed str param type to onestring and refactored code.
Aug 15 2022, 4:03 PM

Aug 14 2022

jcmcdonald requested changes to D528: refactor: changed str param type to onestring and refactored code.
Aug 14 2022, 6:46 PM

Aug 13 2022

jcmcdonald accepted D495: Created Blueshell class. Created function for 'interactive'.

Top shelf work here, sir! I don't mind if you leave some of the test code in place for now, as you have some other work on your docket I believe. Let's land this.

Aug 13 2022, 7:29 PM · Programming [Dept], IOSqueak [Project]
jcmcdonald updated the test plan for D496: IODecor.
Aug 13 2022, 7:27 PM · Programming [Dept], IOSqueak [Project]
jcmcdonald updated the diff for D496: IODecor.
  • feat: natively poll the terminal width
  • feat: add IODecorFill
  • feat: IODecorCenter
  • feat: make IODecor_Absorber use stringify
  • feat: IODecorLeft and IODecorRight
  • fix: fallback width on terminals with no reported width
Aug 13 2022, 7:18 PM · Programming [Dept], IOSqueak [Project]
jcmcdonald added a task to D496: IODecor: Unknown Object (Maniphest Task).
Aug 13 2022, 9:55 AM · Programming [Dept], IOSqueak [Project]
jcmcdonald added a comment to D495: Created Blueshell class. Created function for 'interactive'.

I cannot presently build because hpp/testregister.hpp is absent, but still used. Let me know when you've refactored that out of the library, if you can. If you need to move those files to iosqueak_tester so they're still available for testing this out, that's fine.

Aug 13 2022, 9:53 AM · Programming [Dept], IOSqueak [Project]
jcmcdonald removed a project from T1541: Spike: Run Docker in Docker: Announce [Control].
Aug 13 2022, 9:27 AM · DevNet [Project], Build System [Project]
jcmcdonald added a comment to T1558: Change param type from string to onestring.

I described this in some more detail here: D527#inline-5319

Aug 13 2022, 9:27 AM · Onestring [Project], Programming [Dept]
jcmcdonald requested changes to D527: Onestring: find_last_not_of().
Aug 13 2022, 9:26 AM · Programming [Dept], Onestring [Project]
jcmcdonald added a comment to T1549: feature: create find_last_not_of() on Onestring.

@vperea It's a good habit to link your Differential to the task it's related to. That prevents confusion, and makes it possible to move seamlessly between the tasks and the work being done.

Aug 13 2022, 9:14 AM · Onestring [Project], PawLIB [Project] (2.1), Programming [Dept]
jcmcdonald requested changes to D525: Creates abstract base class ReportBase. Doesn't do anything yet.
Aug 13 2022, 9:13 AM · Programming [Dept], Goldilocks [Project]

Aug 12 2022

jcmcdonald requested changes to D528: refactor: changed str param type to onestring and refactored code.
Aug 12 2022, 3:58 AM

Jul 29 2022

jcmcdonald accepted D524: feat: Onestring: find_first_not_of().
Jul 29 2022, 6:06 PM

Jul 27 2022

jcmcdonald requested changes to D525: Creates abstract base class ReportBase. Doesn't do anything yet.
Jul 27 2022, 9:07 AM · Programming [Dept], Goldilocks [Project]
jcmcdonald accepted rONE86116c89d4f1: feat: changed find return value to int.
Jul 27 2022, 8:55 AM
jcmcdonald accepted rONE61643108215f: feat: completed find algorithm to search strings within a onestring.
Jul 27 2022, 8:55 AM
jcmcdonald accepted rONE93c79f563b75: feat: changed error message.
Jul 27 2022, 8:55 AM
jcmcdonald accepted rONEc64ef15ba673: feat: created script for find func on onestring.
Jul 27 2022, 8:55 AM
jcmcdonald requested changes to D524: feat: Onestring: find_first_not_of().

Great work! I only have one remaining comment.

Jul 27 2022, 8:54 AM
jcmcdonald accepted D526: ci: add arcanist-clang-format-linter Dockerfiles.

This should be fine. Be advised, when you do the image for Jammy, you'll need to install Arcanist and arcanist-clang-format-linter manually from source instead, as well as PHP 7.4. But that doesn't apply here.

Jul 27 2022, 8:51 AM

Jul 25 2022

jcmcdonald added a comment to D495: Created Blueshell class. Created function for 'interactive'.

That's fine.

Jul 25 2022, 11:45 AM · Programming [Dept], IOSqueak [Project]
jcmcdonald changed the status of T1549: feature: create find_last_not_of() on Onestring, a subtask of T1313: Onestring: find() functions, from Proposed to Open.
Jul 25 2022, 7:28 AM · Onestring [Project], PawLIB [Project] (2.1), Help Wanted [Control], Programming [Dept]
jcmcdonald changed the status of T1549: feature: create find_last_not_of() on Onestring from Proposed to Open.

Good job. However, since you're part of the actual project, you can use the User Story next time.

Jul 25 2022, 7:28 AM · Onestring [Project], PawLIB [Project] (2.1), Programming [Dept]
jcmcdonald requested changes to D495: Created Blueshell class. Created function for 'interactive'.

Remember to address the linter errors. I've added a couple of notes. Are you ready for a full review?

Jul 25 2022, 7:25 AM · Programming [Dept], IOSqueak [Project]

Jul 24 2022

jcmcdonald added a member for Intern [Group]: vperea.
Jul 24 2022, 11:15 AM

Jul 23 2022

jcmcdonald requested changes to D524: feat: Onestring: find_first_not_of().
Jul 23 2022, 11:11 AM
jcmcdonald accepted D523: feat: created script for find func on onestring.
Jul 23 2022, 11:05 AM
jcmcdonald edited P1 Revision Checklist.
Jul 23 2022, 11:02 AM · Standards Board [Access], Programming [Dept]
jcmcdonald removed a member for Provisional Intern [Group]: jalopez.
Jul 23 2022, 10:07 AM
jcmcdonald removed a member for Provisional Intern [Group]: vperea.
Jul 23 2022, 10:07 AM
jcmcdonald added members for Mentors [Group]: wdede, galmonte.
Jul 23 2022, 10:07 AM
jcmcdonald added a member for Intern [Group]: jalopez.
Jul 23 2022, 10:06 AM
jcmcdonald removed a member for Intern [Group]: tfu.
Jul 23 2022, 10:06 AM
jcmcdonald removed a member for Intern [Group]: galmonte.
Jul 23 2022, 10:06 AM

Jul 21 2022

jcmcdonald added inline comments to D524: feat: Onestring: find_first_not_of().
Jul 21 2022, 7:45 PM

Jul 16 2022

jcmcdonald committed rDEVDOCd0c19cb48f1a: docs: fix alt install instructions for arcanist (authored by jcmcdonald).
docs: fix alt install instructions for arcanist
Jul 16 2022, 6:17 PM
jcmcdonald requested changes to D523: feat: created script for find func on onestring.
Jul 16 2022, 5:55 PM
jcmcdonald changed the status of Restricted Maniphest Task, a subtask of T1313: Onestring: find() functions, from Proposed to Open.
Jul 16 2022, 10:07 AM · Onestring [Project], PawLIB [Project] (2.1), Help Wanted [Control], Programming [Dept]
jcmcdonald added a subtask for T1313: Onestring: find() functions: Unknown Object (Maniphest Task).
Jul 16 2022, 10:07 AM · Onestring [Project], PawLIB [Project] (2.1), Help Wanted [Control], Programming [Dept]

Jul 12 2022

jcmcdonald requested changes to D523: feat: created script for find func on onestring.

Thanks for your work with this!

Jul 12 2022, 6:51 PM

Jun 29 2022

jcmcdonald added a member for Goldilocks [Project]: jdtolmie.
Jun 29 2022, 11:51 AM
jcmcdonald requested changes to D495: Created Blueshell class. Created function for 'interactive'.

Minor feedback.

Jun 29 2022, 6:12 AM · Programming [Dept], IOSqueak [Project]

Jun 27 2022

jcmcdonald added inline comments to D495: Created Blueshell class. Created function for 'interactive'.
Jun 27 2022, 10:58 AM · Programming [Dept], IOSqueak [Project]
jcmcdonald requested changes to D495: Created Blueshell class. Created function for 'interactive'.

You're making good progress, but I think you've gotten hung up on a familiar snag.

Jun 27 2022, 6:20 AM · Programming [Dept], IOSqueak [Project]

Jun 25 2022

jcmcdonald added a comment to T1541: Spike: Run Docker in Docker.

The title and description both need more context. At a glance, I have no idea what this is about.

Jun 25 2022, 2:44 PM · DevNet [Project], Build System [Project]

Jun 16 2022

jcmcdonald accepted D506: build: make history immutable to arcanist on stable branch.
Jun 16 2022, 11:37 AM · Programming [Dept], Goldilocks [Project]
jcmcdonald added a reviewer for D495: Created Blueshell class. Created function for 'interactive': vperea.
Jun 16 2022, 11:36 AM · Programming [Dept], IOSqueak [Project]

Jun 15 2022

jcmcdonald accepted D500: build: make history immutable to arcanist.
Jun 15 2022, 7:18 PM · Programming [Dept], IMF [Team], Anari [Project]
jcmcdonald accepted D501: build: make history immutable to arcanist.
Jun 15 2022, 7:17 PM
jcmcdonald accepted D503: build: make history immutable to arcanist.
Jun 15 2022, 7:17 PM · Programming [Dept], Network Docs [Project]
jcmcdonald accepted D504: build: make history immutable to arcanist.
Jun 15 2022, 7:17 PM · Programming [Dept], Network Docs [Project]
jcmcdonald accepted D505: build: make history immutable to arcanist on devel branch.
Jun 15 2022, 7:17 PM · Programming [Dept], Goldilocks [Project]
jcmcdonald accepted D507: build: make history immutable to arcanist.
Jun 15 2022, 7:17 PM · Programming [Dept], Goldilocks [Project]
jcmcdonald accepted D508: build: make history immutable to arcanist.
Jun 15 2022, 7:17 PM · Programming [Dept], IOSqueak [Project]
jcmcdonald accepted D509: build: make history immutable to arcanist.
Jun 15 2022, 7:17 PM · Programming [Dept], Lightrift Game Studio [Project]
jcmcdonald accepted D510: build: make history immutable to arcanist on devel branch.
Jun 15 2022, 7:17 PM
jcmcdonald accepted D511: build: make history immutable to arcanist on stable branch.
Jun 15 2022, 7:17 PM
jcmcdonald accepted D512: build: make history immutable to arcanist.
Jun 15 2022, 7:16 PM
jcmcdonald accepted D513: build: make history immutable to arcanist.
Jun 15 2022, 7:16 PM
jcmcdonald accepted D514: build: make history immutable to arcanist.
Jun 15 2022, 7:16 PM · SIMPLEXpress [Project], Programming [Dept]
jcmcdonald accepted D502: build: make history immutable to arcanist.
Jun 15 2022, 7:16 PM
jcmcdonald accepted D515: build: make history immutable to arcanist.
Jun 15 2022, 7:15 PM · Stormsound [Project], Programming [Dept]
jcmcdonald accepted D516: build: make history immutable to arcanist on devel branch.
Jun 15 2022, 7:15 PM
jcmcdonald accepted D517: build: make history immutable to arcanist on stable branch.
Jun 15 2022, 7:15 PM
jcmcdonald accepted D518: build: make history immutable to arcanist.
Jun 15 2022, 7:14 PM
jcmcdonald accepted D519: build: make history immutable to arcanist on devel.
Jun 15 2022, 7:14 PM
jcmcdonald accepted D520: build: make history immutable to arcanist on stable.
Jun 15 2022, 7:14 PM
jcmcdonald accepted D521: build: make history immutable to arcanist on devel.
Jun 15 2022, 7:14 PM · Website [Project], Programming [Dept]
jcmcdonald accepted D522: build: make history immutable to arcanist on stable.
Jun 15 2022, 7:13 PM · Website [Project], Programming [Dept]

Jun 11 2022

jcmcdonald committed rWP5ed13d92cdd8: build: make history immutable to arcanist (authored by jcmcdonald).
build: make history immutable to arcanist
Jun 11 2022, 3:18 PM
jcmcdonald committed rREDc9f044c3caee: build: make history immutable to arcanist (authored by jcmcdonald).
build: make history immutable to arcanist
Jun 11 2022, 3:09 PM
jcmcdonald committed rPL69122722e88e: build: make history immutable to arcanist (authored by jcmcdonald).
build: make history immutable to arcanist
Jun 11 2022, 3:08 PM
jcmcdonald committed rK510b24e9184e: build: make history immutable to arcanist (authored by jcmcdonald).
build: make history immutable to arcanist
Jun 11 2022, 2:59 PM
jcmcdonald committed rOd122deed0642: build: make history immutable to arcanist (authored by jcmcdonald).
build: make history immutable to arcanist
Jun 11 2022, 2:59 PM
jcmcdonald committed rINFb99152c31beb: build: make history immutable to arcanist (authored by jcmcdonald).
build: make history immutable to arcanist
Jun 11 2022, 2:51 PM
jcmcdonald committed rDQ0f1488cffcee: Merge branch 'devel' of ssh://phab.mousepawmedia.com:2222/source/diamondquest… (authored by jcmcdonald).
Merge branch 'devel' of ssh://phab.mousepawmedia.com:2222/source/diamondquest…
Jun 11 2022, 2:32 PM
jcmcdonald committed rDQ0f7579c5511f: build: update repo URL and make history immutable to arcanist (authored by jcmcdonald).
build: update repo URL and make history immutable to arcanist
Jun 11 2022, 2:32 PM
jcmcdonald committed rCCf93e0034b9e9: Merge branch 'devel' of ssh://phab.mousepawmedia.com:2222/source/calikocat into… (authored by jcmcdonald).
Merge branch 'devel' of ssh://phab.mousepawmedia.com:2222/source/calikocat into…
Jun 11 2022, 2:01 PM
jcmcdonald committed rCC27aed5be44a6: build: update repo URL and make history immutable to arcanist (authored by jcmcdonald).
build: update repo URL and make history immutable to arcanist
Jun 11 2022, 2:01 PM

Jun 8 2022

jcmcdonald accepted D499: created copyArchives.groovy.
Jun 8 2022, 6:37 PM
jcmcdonald accepted D497: Script for build and publish docker images.
Jun 8 2022, 5:47 PM
jcmcdonald requested changes to D497: Script for build and publish docker images.

There are some other changes still here that don't seem to be related to the goal of the Differential.

Jun 8 2022, 5:45 PM
jcmcdonald requested changes to D497: Script for build and publish docker images.
Jun 8 2022, 9:08 AM

Jun 4 2022

jcmcdonald requested changes to D495: Created Blueshell class. Created function for 'interactive'.

Beyond this last detaill, do you feel this is ready to land, @jdtolmie?

Jun 4 2022, 8:22 PM · Programming [Dept], IOSqueak [Project]