You'll want to remove commented out code completely in most cases. The only time you'd keep is if future developers need to be able to comment/uncomment it to turn on/off some sort of debugging statement.

This is looking pretty good! Minor notes, mostly unrelated to the code itself.

In D345#17258, @wdede wrote:

In D345#15149, @jcmcdonald wrote:

@wdede You'll want to commandeer this revision from the Add Action... menu at the bottom.

The option disappeared for some reason.

Ahh, tracking with you now. This is abandoned. So, on the bottom of the Differential you want to abandon, and go to Add Action... → Abandon Revision.

This is excellent, well done.

Top shelf work here, sir! I don't mind if you leave some of the test code in place for now, as you have some other work on your docket I believe. Let's land this.

• feat: natively poll the terminal width
• feat: add IODecorFill
• feat: IODecorCenter
• feat: make IODecor_Absorber use stringify
• feat: IODecorLeft and IODecorRight
• fix: fallback width on terminals with no reported width

I cannot presently build because hpp/testregister.hpp is absent, but still used. Let me know when you've refactored that out of the library, if you can. If you need to move those files to iosqueak_tester so they're still available for testing this out, that's fine.

I described this in some more detail here: D527#inline-5319

@vperea It's a good habit to link your Differential to the task it's related to. That prevents confusion, and makes it possible to move seamlessly between the tasks and the work being done.

Great work! I only have one remaining comment.

This should be fine. Be advised, when you do the image for Jammy, you'll need to install Arcanist and arcanist-clang-format-linter manually from source instead, as well as PHP 7.4. But that doesn't apply here.

That's fine.

Good job. However, since you're part of the actual project, you can use the User Story next time.

Remember to address the linter errors. I've added a couple of notes. Are you ready for a full review?

Thanks for your work with this!

Minor feedback.

You're making good progress, but I think you've gotten hung up on a familiar snag.

The title and description both need more context. At a glance, I have no idea what this is about.

There are some other changes still here that don't seem to be related to the goal of the Differential.

Beyond this last detaill, do you feel this is ready to land, @jdtolmie?