Page MenuHomePhabricator
Feed All Stories

Today

galmonte accepted D530: Set up new branch as old one was corrupted..
Wed, Aug 17, 8:09 AM · Programming [Dept], IOSqueak [Project]
jdtolmie requested review of D530: Set up new branch as old one was corrupted..
Wed, Aug 17, 7:54 AM · Programming [Dept], IOSqueak [Project]

Yesterday

galmonte retitled D529: feat: conestring::rfind() from feat: created rfind with 2 overloaded function to feat: conestring::rfind().
Tue, Aug 16, 9:04 PM
galmonte planned changes to D529: feat: conestring::rfind().
Tue, Aug 16, 9:03 PM
galmonte requested review of D529: feat: conestring::rfind().
Tue, Aug 16, 9:03 PM
galmonte added a revision to T1553: Implenent string::rfind() on Onestring: D529: feat: conestring::rfind().
Tue, Aug 16, 9:03 PM · Onestring [Project], PawLIB [Project] (2.1), Help Wanted [Control], Programming [Dept], Announce [Control]
jdtolmie added inline comments to D495: Created Blueshell class. Created function for 'interactive'.
Tue, Aug 16, 9:30 AM · Programming [Dept], IOSqueak [Project]

Mon, Aug 15

galmonte closed T1558: Change param type from string to onestring, a subtask of T1553: Implenent string::rfind() on Onestring, as Completed.
Mon, Aug 15, 7:14 PM · Onestring [Project], PawLIB [Project] (2.1), Help Wanted [Control], Programming [Dept], Announce [Control]
galmonte closed T1558: Change param type from string to onestring as Completed.
Mon, Aug 15, 7:14 PM · Onestring [Project], Programming [Dept]
galmonte committed rONE6c924f91d09c: refactor: changed str param type to onestring and refactored code (authored by galmonte).
refactor: changed str param type to onestring and refactored code
Mon, Aug 15, 5:52 PM
galmonte committed rONE03965b50cdec: refactor: created 2 find overload func and changed condition within 2nd loop (authored by galmonte).
refactor: created 2 find overload func and changed condition within 2nd loop
Mon, Aug 15, 5:52 PM
galmonte committed rONEc21926f1b739: test: added tests for emojis (authored by galmonte).
test: added tests for emojis
Mon, Aug 15, 5:52 PM
galmonte closed D528: refactor: changed str param type to onestring and refactored code.
Mon, Aug 15, 5:52 PM
galmonte committed rONE62ff5ebbb04c: refactor: changed str param type to onestring and refactored code (authored by galmonte).
refactor: changed str param type to onestring and refactored code
Mon, Aug 15, 5:52 PM
jcmcdonald accepted D528: refactor: changed str param type to onestring and refactored code.
Mon, Aug 15, 4:03 PM
galmonte updated the diff for D528: refactor: changed str param type to onestring and refactored code.
  • test: added tests for emojis
Mon, Aug 15, 3:53 PM
galmonte removed projects from T1558: Change param type from string to onestring: Urgent ⚠ [Control], Announce [Control].
Mon, Aug 15, 1:50 PM · Onestring [Project], Programming [Dept]

Sun, Aug 14

jcmcdonald requested changes to D528: refactor: changed str param type to onestring and refactored code.
Sun, Aug 14, 6:46 PM
galmonte updated the diff for D528: refactor: changed str param type to onestring and refactored code.
  • refactor: created 2 find overload func and changed condition within 2nd loop
Sun, Aug 14, 6:06 PM

Sat, Aug 13

jcmcdonald accepted D495: Created Blueshell class. Created function for 'interactive'.

Top shelf work here, sir! I don't mind if you leave some of the test code in place for now, as you have some other work on your docket I believe. Let's land this.

Sat, Aug 13, 7:29 PM · Programming [Dept], IOSqueak [Project]
jcmcdonald updated the test plan for D496: IODecor.
Sat, Aug 13, 7:27 PM · Programming [Dept], IOSqueak [Project]
jcmcdonald updated the diff for D496: IODecor.
  • feat: natively poll the terminal width
  • feat: add IODecorFill
  • feat: IODecorCenter
  • feat: make IODecor_Absorber use stringify
  • feat: IODecorLeft and IODecorRight
  • fix: fallback width on terminals with no reported width
Sat, Aug 13, 7:18 PM · Programming [Dept], IOSqueak [Project]
jdtolmie updated the diff for D495: Created Blueshell class. Created function for 'interactive'.
  • Added testregister.hpp for testing purposes.
Sat, Aug 13, 10:45 AM · Programming [Dept], IOSqueak [Project]
jcmcdonald added a task to D496: IODecor: Unknown Object (Maniphest Task).
Sat, Aug 13, 9:55 AM · Programming [Dept], IOSqueak [Project]
jcmcdonald added a comment to D495: Created Blueshell class. Created function for 'interactive'.

I cannot presently build because hpp/testregister.hpp is absent, but still used. Let me know when you've refactored that out, if you can.

Sat, Aug 13, 9:53 AM · Programming [Dept], IOSqueak [Project]
jcmcdonald removed a project from T1541: Spike: Run Docker in Docker: Announce [Control].
Sat, Aug 13, 9:27 AM · DevNet [Project], Build System [Project]
jcmcdonald added a comment to T1558: Change param type from string to onestring.

I described this in some more detail here: D527#inline-5319

Sat, Aug 13, 9:27 AM · Onestring [Project], Programming [Dept]
jcmcdonald requested changes to D527: Onestring: find_last_not_of().
Sat, Aug 13, 9:26 AM · Programming [Dept], Announce [Control], Onestring [Project]
jcmcdonald added a comment to T1549: feature: create find_last_not_of() on Onestring.

@vperea It's a good habit to link your Differential to the task it's related to. Here on the task, go to Edit Related Objects...Edit Revisions.

Sat, Aug 13, 9:14 AM · Announce [Control], Onestring [Project], PawLIB [Project] (2.1), Programming [Dept]
jcmcdonald requested changes to D525: Creates abstract base class ReportBase. Doesn't do anything yet.
Sat, Aug 13, 9:13 AM · Programming [Dept], Goldilocks [Project]

Fri, Aug 12

jcmcdonald requested changes to D528: refactor: changed str param type to onestring and refactored code.
Fri, Aug 12, 3:58 AM

Thu, Aug 11

galmonte added a reviewer for D528: refactor: changed str param type to onestring and refactored code: jcmcdonald.
Thu, Aug 11, 8:08 PM
galmonte added a comment to T1549: feature: create find_last_not_of() on Onestring.

I got confused, my bad 😅

Thu, Aug 11, 8:07 PM · Announce [Control], Onestring [Project], PawLIB [Project] (2.1), Programming [Dept]
galmonte added a revision to T1558: Change param type from string to onestring: D528: refactor: changed str param type to onestring and refactored code.
Thu, Aug 11, 8:02 PM · Onestring [Project], Programming [Dept]
galmonte requested review of D528: refactor: changed str param type to onestring and refactored code.
Thu, Aug 11, 8:02 PM
galmonte claimed T1558: Change param type from string to onestring.
Thu, Aug 11, 7:49 PM · Onestring [Project], Programming [Dept]
galmonte added a comment to T1558: Change param type from string to onestring.

This task is blocking T1553 and T1549

Thu, Aug 11, 7:49 PM · Onestring [Project], Programming [Dept]
galmonte changed the status of T1558: Change param type from string to onestring, a subtask of T1553: Implenent string::rfind() on Onestring, from Proposed to Open.
Thu, Aug 11, 7:46 PM · Onestring [Project], PawLIB [Project] (2.1), Help Wanted [Control], Programming [Dept], Announce [Control]
galmonte changed the status of T1558: Change param type from string to onestring from Proposed to Open.
Thu, Aug 11, 7:46 PM · Onestring [Project], Programming [Dept]
galmonte created T1558: Change param type from string to onestring.
Thu, Aug 11, 7:46 PM · Onestring [Project], Programming [Dept]
galmonte added a comment to D527: Onestring: find_last_not_of().

Let's create a new sub task, so we can go back to onestring::find_first_not_of() and make the changes I suggested to make on that function. Right after we land those changes rebase that onto this revision. and after that this will be ready to land.

Thu, Aug 11, 7:38 PM · Programming [Dept], Announce [Control], Onestring [Project]

Wed, Aug 10

vperea added a comment to D527: Onestring: find_last_not_of().

Good job, Vanesa. I see that you have improved your CPP skills.

Wed, Aug 10, 3:44 AM · Programming [Dept], Announce [Control], Onestring [Project]
vperea updated the diff for D527: Onestring: find_last_not_of().
-I have change the conditional for i starting value and some test related to it. I was confused at counting the characters to be included.
Wed, Aug 10, 3:22 AM · Programming [Dept], Announce [Control], Onestring [Project]

Tue, Aug 9

jalopez added inline comments to D495: Created Blueshell class. Created function for 'interactive'.
Tue, Aug 9, 9:25 PM · Programming [Dept], IOSqueak [Project]
galmonte requested changes to D527: Onestring: find_last_not_of().

Good job, Vanesa. I see that you have improved your CPP skills.

Tue, Aug 9, 5:52 PM · Programming [Dept], Announce [Control], Onestring [Project]

Mon, Aug 8

vperea added a member for Website [Project]: vperea.
Mon, Aug 8, 7:31 AM
vperea added a comment to D527: Onestring: find_last_not_of().

I'm trying to deal with the unsignedPositive issue, the problem I think is that the loop finishes when 'i' is 0 so when the last character not matching is in the position 0 (letter t in this case) it does not detect it.

Mon, Aug 8, 2:57 AM · Programming [Dept], Announce [Control], Onestring [Project]
vperea updated the diff for D527: Onestring: find_last_not_of().
  • refractor: address format linter issues
  • refractor: improve the function with a reverse loop. Starting from the end of the string reduces the number of iterations and there is no need for store the i value in a variable.
Mon, Aug 8, 2:07 AM · Programming [Dept], Announce [Control], Onestring [Project]

Fri, Aug 5

galmonte closed T1537: Configure pass in Dockerfile, a subtask of T1454: Jenkins Matrix Build, as Invalid.
Fri, Aug 5, 8:12 PM · DevNet [Project], Build System [Project]
galmonte closed T1537: Configure pass in Dockerfile as Invalid.
Fri, Aug 5, 8:12 PM · DevNet [Project], Build System [Project]

Thu, Aug 4

jdtolmie updated the diff for D495: Created Blueshell class. Created function for 'interactive'.
  • Feat: Added 'history' command, and bang history command.
Thu, Aug 4, 7:08 PM · Programming [Dept], IOSqueak [Project]
jdtolmie updated the diff for D495: Created Blueshell class. Created function for 'interactive'.
  • Feat: Added 'history' command, and bang history command.
Thu, Aug 4, 7:03 PM · Programming [Dept], IOSqueak [Project]

Wed, Aug 3

vperea added a comment to T1549: feature: create find_last_not_of() on Onestring.

If you landed your Onestring::find_last_not_of differential, you can close this subtask and create a new subtask for Onestring::find_last_not_of().

Wed, Aug 3, 1:15 AM · Announce [Control], Onestring [Project], PawLIB [Project] (2.1), Programming [Dept]

Tue, Aug 2

galmonte added a comment to T1549: feature: create find_last_not_of() on Onestring.

If you landed your Onestring::find_last_not_of differential, you can close this subtask and create a new subtask for Onestring::find_last_not_of().

Tue, Aug 2, 8:43 PM · Announce [Control], Onestring [Project], PawLIB [Project] (2.1), Programming [Dept]
vperea claimed T1549: feature: create find_last_not_of() on Onestring.
Tue, Aug 2, 10:15 AM · Announce [Control], Onestring [Project], PawLIB [Project] (2.1), Programming [Dept]
vperea changed the status of T1549: feature: create find_last_not_of() on Onestring, a subtask of T1313: Onestring: find() functions, from Open to Pending Review.
Tue, Aug 2, 10:14 AM · Onestring [Project], PawLIB [Project] (2.1), Help Wanted [Control], Programming [Dept]
vperea changed the status of T1549: feature: create find_last_not_of() on Onestring from Open to Pending Review.
Tue, Aug 2, 10:14 AM · Announce [Control], Onestring [Project], PawLIB [Project] (2.1), Programming [Dept]
vperea updated the summary of D527: Onestring: find_last_not_of().
Tue, Aug 2, 9:50 AM · Programming [Dept], Announce [Control], Onestring [Project]
vperea requested review of D527: Onestring: find_last_not_of().
Tue, Aug 2, 9:47 AM · Programming [Dept], Announce [Control], Onestring [Project]
vperea added a revision to T1549: feature: create find_last_not_of() on Onestring: D527: Onestring: find_last_not_of().
Tue, Aug 2, 9:47 AM · Announce [Control], Onestring [Project], PawLIB [Project] (2.1), Programming [Dept]

Mon, Aug 1

wdede added a reviewer for D525: Creates abstract base class ReportBase. Doesn't do anything yet: jcmcdonald.
Mon, Aug 1, 5:56 PM · Programming [Dept], Goldilocks [Project]
wdede removed a reviewer for D525: Creates abstract base class ReportBase. Doesn't do anything yet: jcmcdonald.
Mon, Aug 1, 5:55 PM · Programming [Dept], Goldilocks [Project]
wdede updated the diff for D525: Creates abstract base class ReportBase. Doesn't do anything yet.
  • Fixes lint warnings about override functions.
Mon, Aug 1, 5:53 PM · Programming [Dept], Goldilocks [Project]
wdede updated the diff for D525: Creates abstract base class ReportBase. Doesn't do anything yet.
  • Creates abstraction and inheritance between ReportBase, Report and BenchmarkReport.
Mon, Aug 1, 5:50 PM · Programming [Dept], Goldilocks [Project]
jdtolmie updated the diff for D495: Created Blueshell class. Created function for 'interactive'.
  • Feat: Added tab functionality to fill in partial typed commands with any that match. If multiple are available, it will print them to the terminal, and fill in as much as matches all of the commands.
Mon, Aug 1, 2:54 PM · Programming [Dept], IOSqueak [Project]
vperea updated the task description for T1313: Onestring: find() functions.
Mon, Aug 1, 1:51 AM · Onestring [Project], PawLIB [Project] (2.1), Help Wanted [Control], Programming [Dept]
vperea closed Restricted Maniphest Task, a subtask of T1313: Onestring: find() functions, as Completed.
Mon, Aug 1, 1:50 AM · Onestring [Project], PawLIB [Project] (2.1), Help Wanted [Control], Programming [Dept]
MinervaLong <vanesa.perea.cuevas@gmail.com> committed rONE52900ad63cda: feat: Onestring: find_first_not_of() (authored by MinervaLong <vanesa.perea.cuevas@gmail.com>).
feat: Onestring: find_first_not_of()
Mon, Aug 1, 1:49 AM
MinervaLong <vanesa.perea.cuevas@gmail.com> committed rONE737c1cd9ccf9: refractor: address linter format issues (authored by MinervaLong <vanesa.perea.cuevas@gmail.com>).
refractor: address linter format issues
Mon, Aug 1, 1:49 AM
MinervaLong <vanesa.perea.cuevas@gmail.com> committed rONEfebe65a156d4: refractor: correct a misunderstood word (authored by MinervaLong <vanesa.perea.cuevas@gmail.com>).
refractor: correct a misunderstood word
Mon, Aug 1, 1:49 AM
MinervaLong <vanesa.perea.cuevas@gmail.com> committed rONE6e39c0786a90: refractor: improve comments (authored by MinervaLong <vanesa.perea.cuevas@gmail.com>).
refractor: improve comments
Mon, Aug 1, 1:49 AM
MinervaLong <vanesa.perea.cuevas@gmail.com> committed rONE7ec2381998a6: refractor: use find() to search char coincidence. (authored by MinervaLong <vanesa.perea.cuevas@gmail.com>).
refractor: use find() to search char coincidence.
Mon, Aug 1, 1:49 AM
MinervaLong <vanesa.perea.cuevas@gmail.com> committed rONE7f7c78a69c89: Merge branch 'devel' into T1547_find_first_not_of_function (authored by MinervaLong <vanesa.perea.cuevas@gmail.com>).
Merge branch 'devel' into T1547_find_first_not_of_function
Mon, Aug 1, 1:49 AM
MinervaLong <vanesa.perea.cuevas@gmail.com> committed rONE0ae59a852eac: refractor: improve the comments (authored by MinervaLong <vanesa.perea.cuevas@gmail.com>).
refractor: improve the comments
Mon, Aug 1, 1:49 AM
MinervaLong <vanesa.perea.cuevas@gmail.com> committed rONE9322e9d294cf: refractor: change to prefix notation at loops (authored by MinervaLong <vanesa.perea.cuevas@gmail.com>).
refractor: change to prefix notation at loops
Mon, Aug 1, 1:49 AM
MinervaLong <vanesa.perea.cuevas@gmail.com> committed rONEe25f7c5ddb41: refractor: address variable scope linter issue (authored by MinervaLong <vanesa.perea.cuevas@gmail.com>).
refractor: address variable scope linter issue
Mon, Aug 1, 1:49 AM
MinervaLong <vanesa.perea.cuevas@gmail.com> committed rONE07ace2bed920: refractor: address unreadVariable linter issue (authored by MinervaLong <vanesa.perea.cuevas@gmail.com>).
refractor: address unreadVariable linter issue
Mon, Aug 1, 1:49 AM
MinervaLong <vanesa.perea.cuevas@gmail.com> committed rONE512d9302e42c: refractor: address linter issues (authored by MinervaLong <vanesa.perea.cuevas@gmail.com>).
refractor: address linter issues
Mon, Aug 1, 1:49 AM
MinervaLong <vanesa.perea.cuevas@gmail.com> committed rONEa8863fc0ecd8: feat: add tests for find_first_not_of() (authored by MinervaLong <vanesa.perea.cuevas@gmail.com>).
feat: add tests for find_first_not_of()
Mon, Aug 1, 1:48 AM
MinervaLong <vanesa.perea.cuevas@gmail.com> closed D524: feat: Onestring: find_first_not_of().
Mon, Aug 1, 1:48 AM
MinervaLong <vanesa.perea.cuevas@gmail.com> committed rONE0f5800cca160: feat: add find_first_not_of function (authored by MinervaLong <vanesa.perea.cuevas@gmail.com>).
feat: add find_first_not_of function
Mon, Aug 1, 1:48 AM

Sun, Jul 31

wdede claimed T1511: Results vector modification needed.
Sun, Jul 31, 10:45 AM · Goldilocks [Project], Announce [Control], Programming [Dept]
wdede claimed T1505: Benchmark_Report class.
Sun, Jul 31, 10:45 AM · Goldilocks [Project], Programming [Dept]

Fri, Jul 29

jcmcdonald accepted D524: feat: Onestring: find_first_not_of().
Fri, Jul 29, 6:06 PM
jdtolmie updated the diff for D495: Created Blueshell class. Created function for 'interactive'.
  • Feat: Made a lot of changes. Moved most functions into their own file. Pressing tab mostly works for listing stored functions, and if a partial command was typed, it will search for any starting with that. Fixed some issues with arrow keypress, and added a call to tab if using arrows, then pressing tab.
Fri, Jul 29, 5:38 PM · Programming [Dept], IOSqueak [Project]
jdtolmie planned changes to D495: Created Blueshell class. Created function for 'interactive'.

There is one or more things I need to fix on up/down key press before review.

Fri, Jul 29, 10:58 AM · Programming [Dept], IOSqueak [Project]
jdtolmie updated the diff for D495: Created Blueshell class. Created function for 'interactive'.
  • Fix: Fixed issue with up/down arrow press having to be pressed twice when pressing opposite arrow press (having to press down twice to start traversing again etc). Added comments to that part of the code.
Fri, Jul 29, 9:06 AM · Programming [Dept], IOSqueak [Project]

Thu, Jul 28

jdtolmie planned changes to D495: Created Blueshell class. Created function for 'interactive'.

Planning on working on this again soon. The lint warnings I do not know how to fix, as I need this code as is (as far as I can tell). If I can find a solution to solving this issue, I will fix it then.

Thu, Jul 28, 7:40 PM · Programming [Dept], IOSqueak [Project]
jdtolmie updated the diff for D495: Created Blueshell class. Created function for 'interactive'.

Trying to find lint errors

Thu, Jul 28, 7:34 PM · Programming [Dept], IOSqueak [Project]
jdtolmie updated the diff for D495: Created Blueshell class. Created function for 'interactive'.
  • feat: Got up/down arrow press traversing the 'previous_command' vector. Pressing 'enter' will call up the command. One issue is that if part way through the vector, you have to press the down arrow twice before if starts down again. It calls up the print_line function with the same vector element. Would like to find a way to fix that.
Thu, Jul 28, 7:33 PM · Programming [Dept], IOSqueak [Project]
galmonte accepted D524: feat: Onestring: find_first_not_of().
Thu, Jul 28, 7:06 PM
galmonte changed the status of T1553: Implenent string::rfind() on Onestring, a subtask of T1313: Onestring: find() functions, from Proposed to Open.
Thu, Jul 28, 7:05 PM · Onestring [Project], PawLIB [Project] (2.1), Help Wanted [Control], Programming [Dept]
galmonte changed the status of T1553: Implenent string::rfind() on Onestring from Proposed to Open.
Thu, Jul 28, 7:05 PM · Onestring [Project], PawLIB [Project] (2.1), Help Wanted [Control], Announce [Control], Programming [Dept]
galmonte created T1553: Implenent string::rfind() on Onestring.
Thu, Jul 28, 7:04 PM · Onestring [Project], PawLIB [Project] (2.1), Help Wanted [Control], Announce [Control], Programming [Dept]
galmonte committed rBLDbe9cbe16560b: ci: deleted buildAndPushDockerfiles.groovy (authored by galmonte).
ci: deleted buildAndPushDockerfiles.groovy
Thu, Jul 28, 6:55 PM
galmonte committed rBLD752c8ea8ba4e: ci: add arcanist-clang-format-linter Dockerfiles (authored by galmonte).
ci: add arcanist-clang-format-linter Dockerfiles
Thu, Jul 28, 6:55 PM
galmonte closed D526: ci: add arcanist-clang-format-linter Dockerfiles.
Thu, Jul 28, 6:55 PM
galmonte committed rBLD552ef97fbe5e: ci: added arcanist-clang-format-linter to the command to install at the… (authored by galmonte).
ci: added arcanist-clang-format-linter to the command to install at the…
Thu, Jul 28, 6:55 PM
vperea updated the diff for D524: feat: Onestring: find_first_not_of().
  • refractor: address linter format issues
  • refractor: correct a misunderstood word
Thu, Jul 28, 6:37 AM
vperea added a comment to D524: feat: Onestring: find_first_not_of().

Great work! I only have one remaining comment.

Thu, Jul 28, 6:31 AM