Page MenuHomePhabricator
Create Task
Maniphest T1319

Implement arcanist-clang-format-linter
Closed, CompletedPublic4 Energy Points (d+f*r)
Actions

Description

Investigate how arcanist can implement the clang-format-linter to format and lint through code at the same time.
This appears to be a package on Ubuntu. If we start using this, it will allow autoformatting as part of diff.

Details

Task Type
Feature
Proposed Urgency
Established
Gravity
g3: Major
Distance
d2: Within Week
Friction
f2: Street
Relativity
r1: Trivial
Volatility (Caught At)
Not a Bug
Origin
Not a Bug/Unknown

Revisions and Commits

rT Trailcrest
D435rTda313f933cff Added clang Linter
rDEVDOC Development Docs
AbandonedD443 Added clang-format-linter instructions
rI IOSqueak
D420rI43ad0a02dea8 Added Clang linter
rST Stormsound
D433rST9a5722e4ee8e Added clang Linter
rCC CalikoCat
D417rCC3d6c2a7abb20 Added linter
rP PawLIB
D428rPe6e62be61524 Added clang Linter
rS SIMPLEXpress
AbandonedD432 Added clang Linter
rONE Onestring
D427rONEd5fea5bb70f5 Added clang Linter
rAT Arctic Tern
D416rAT0cf815569eb8 Added Clang linter
rLIB Third-Party Libraries
D425rLIB65af727c3469 Added Clang Linter
rA Anari
D415rAcf8cb5fb49b7 Added clang-format-linter
rG Goldilocks
AbandonedD418 Goldilocks 1.0 migration from PawLIB
rPL Punchline
D430rPL355ad55e0e55 Added clang Linter
rINF Infiltrator
D419rINF61f49d786983 Added Clang Linter
rTEST Test
ClosedD411 tesing clang format-linter
D434rTESTdc012a80f799 Added clang Linter
rN Nimbly
D426rN13e5f9419630 Added clang Linter
rL Lightrift
D423rLc99f80197de4 Added Clang Linter
rR Ratscript
AbandonedD431 Added clang Linter

Related Objects
Search...

Event Timeline

jcmcdonald created this task.Apr 26 2020, 6:37 PM
galmonte reassigned this task from jcmcdonald to tfu.Jul 3 2021, 12:13 PM
galmonte set Distance to Triage Distance.
galmonte moved this task from Backlog to Current Sprint on the DevNet [Project] board.
galmonte added a subscriber: tfu.
tfu mentioned this in Sprint 2021-07.Jul 3 2021, 12:22 PM
jcmcdonald triaged this task as p4: Now priority.Jul 3 2021, 6:26 PM
jcmcdonald changed Gravity from Triage Gravity to g3: Major.
jcmcdonald changed Distance from Triage Distance to d2: Within Week.
jcmcdonald changed Friction from Triage Friction to f3: Off-Road.
jcmcdonald changed Relativity from Triage Relativity to r1: Trivial.
jcmcdonald set the point value for this task to 5.
jcmcdonald moved this task from Backlog to Current Sprint on the Build System [Project] board.Jul 3 2021, 7:50 PM
tfu changed Friction from f3: Off-Road to f2: Street.Jul 6 2021, 3:13 PM
tfu changed the point value for this task from 5 to 4.
tfu renamed this task from Investigate arcanist-clang-format-linter to Implement arcanist-clang-format-linter.Jul 6 2021, 3:17 PM
tfu updated the task description. (Show Details)
tfu added a comment.Jul 8 2021, 1:30 PM

https://phab.mousepawmedia.com/P56
https://reviews.llvm.org/D49116

tfu added a comment.EditedJul 21 2021, 8:22 PM

D415 - D435 are all adding clang-format-linter to various repositories.

jcmcdonald added a comment.Jul 22 2021, 7:39 AM

🎉 WOOO!

tfu added revisions: D411: tesing clang format-linter, D415: Added clang-format-linter, D416: Added Clang linter, D417: Added linter, D418: Goldilocks 1.0 migration from PawLIB, D419: Added Clang Linter, D420: Added Clang linter, D423: Added Clang Linter, D425: Added Clang Linter, D426: Added clang Linter, D427: Added clang Linter, D428: Added clang Linter, D430: Added clang Linter, D431: Added clang Linter, D432: Added clang Linter, D433: Added clang Linter, D434: Added clang Linter, D435: Added clang Linter.Jul 22 2021, 2:51 PM
tfu added a commit: rAcf8cb5fb49b7: Added clang-format-linter.Jul 29 2021, 2:57 PM
tfu added a commit: rCC3d6c2a7abb20: Added linter.Jul 29 2021, 3:01 PM
tfu added a commit: rINF61f49d786983: Added Clang Linter.
tfu added a commit: rI43ad0a02dea8: Added Clang linter.Jul 29 2021, 3:03 PM
tfu added a commit: rLc99f80197de4: Added Clang Linter.
tfu added a commit: rN13e5f9419630: Added clang Linter.
tfu added a commit: rONEd5fea5bb70f5: Added clang Linter.
tfu added a commit: rPL355ad55e0e55: Added clang Linter.Jul 29 2021, 3:06 PM
tfu added a commit: rTda313f933cff: Added clang Linter.
tfu added a commit: rTESTdc012a80f799: Added clang Linter.Aug 4 2021, 10:17 PM
tfu added a commit: rPe6e62be61524: Added clang Linter.Aug 4 2021, 10:19 PM
tfu added a commit: rLIB65af727c3469: Added Clang Linter.
tfu added a commit: rAT0cf815569eb8: Added Clang linter.Aug 5 2021, 2:04 PM
tfu added a commit: rST9a5722e4ee8e: Added clang Linter.Aug 5 2021, 2:06 PM
jcmcdonald mentioned this in T1492: Waiting for T1477.Aug 6 2021, 10:30 PM
tfu added a parent task: T1477: Memory error in SIMPLEXpress Unit Parser.Aug 10 2021, 8:43 PM
tfu closed subtask T1492: Waiting for T1477 as Invalid.
tfu added a revision: D443: Added clang-format-linter instructions.Sep 3 2021, 8:39 PM
tfu closed this task as Completed.Oct 2 2021, 12:11 PM
galmonte mentioned this in Sprint 2021-10.Oct 2 2021, 12:42 PM
Copyright (C) 2019 MousePaw Media. All Rights Reserved. · Community Rules · Terms of Use · Privacy Policy · Terms of Development