Page MenuHomePhabricator

Hotfix: Change `$<CONFIG>` to `${CMAKE_BUILD_TYPE}`
Closed, CompletedPublic5 Energy Points (d+f*r)

Description

@imirzali and I found a bug in the build system, described in Blog Post: URGENT: Build System Hotfix.

Change every instance of $<CONFIG> to ${CMAKE_BUILD_TYPE} in both of the CMakeLists.txt files in all repositories on master.

Details

Task Type
Bug
Proposed Urgency
Established
Gravity
g5: Critical
Friction
Triage Friction
Relativity
Triage Relativity
Volatility (Caught At)
Not a Bug
Origin
Not a Bug/Unknown

Event Timeline

jcmcdonald triaged this task as p5: Emergency priority.Apr 10 2020, 5:48 PM
jcmcdonald created this task.
jcmcdonald changed the task status from Patched to Completed.Apr 11 2020, 7:11 AM

@imirzali I think you can say "Resolved" or "Completed" instead.

"Patched" is a special close status that means we may need to revisit and fix the problem again. It's used anytime there's a workaround to a bug where the bug is suspected not to be actually resolved; the bug tends to reemerge in cases like that.