Page MenuHomePhabricator

Revision Checklist
ActivePublic

Authored by jcmcdonald on Jan 3 2015, 1:05 PM.
Before landing, each Revision should...
(1) Accomplish the feature(s) it was designed to accomplish. [In some cases, the feature itself may be dropped, and only bugfixes and/or optimizations landed instead.]
(2) Have merged/rebased all changes from `devel` into itself, and all conflicts resolved. ($ git pull --rebase origin devel)
(3) Have binaries and unnecessary cruft untracked and removed. (Keep an eye on .gitignore!)
(4) Compile and run properly - this should be confirmed via Harbormaster/Jenkins (if available).
(5) Be free of compiler errors and warnings (must compile with `-Wall -Wextra -Werror`).
(6) Be Valgrind pure (no memory leaks detected).
(7) Comply with Coding and Technical standards.
(8) Be free of linter errors. ($ arc lint --lintall)
(9) Be fully CSI commented.
(10) Have an up-to-date build script (generally CMake) if relevant.
(11) Contain relevant LIT tests, if the project is Goldilocks capable.
(12) Have a Test Plan, generally containing a list of Goldilocks tests the reviewer should run.
(13) Be reviewed, built, tested, and approved by at least one trusted reviewer (Staff or Trusted Contributor).
(14) Have up-to-date Sphinx documentation, which compiles with no warnings.
(15) Have all reviewer comments processed and marked "Done".

Event Timeline

smcarlson changed the title of this paste from untitled to Unit Tests.
smcarlson updated the paste's language from autodetect to autodetect.
jcmcdonald changed the title of this paste from Unit Tests to Differential Checklist.Aug 30 2016, 12:21 PM
jcmcdonald updated the paste's language from autodetect to remarkup.
jcmcdonald edited the content of this paste. (Show Details)
jcmcdonald added a subscriber: jcmcdonald.

I'm repurposing this paste (because of the handy ID) for the diff checklist.

jcmcdonald updated the paste's language from remarkup to rainbow.
jcmcdonald edited the content of this paste. (Show Details)
jcmcdonald updated the paste's language from rainbow to text.Aug 30 2016, 12:26 PM
jcmcdonald edited the content of this paste. (Show Details)
jcmcdonald changed the edit policy from "All Users" to "Standards Board [Access] (Project)".
jcmcdonald changed the title of this paste from Differential Checklist to Revision Checklist.Mar 4 2017, 6:23 PM
jcmcdonald edited the content of this paste. (Show Details)

Line 4 should be updated to reflect devel branch name. I don't have edit access.