TBD
Details
Diff Detail
- Repository
- rDEVDOC Development Docs
- Lint
Lint Not Applicable
Event Timeline
source/tools/cpp.rst | ||
---|---|---|
152 | Right prose, wrong place. Notice what else is not here: cppcheck, our static analyzer! Find where the setup for that appears in the docs, and put clang-format there instead. |
Excellent.
However, I do believe you also need the arcanist-clang-format-linter package?
Besides that, assuming nothing else is needed, this should be good to go.
source/tools/gitarc.rst | ||
---|---|---|
33 | Just add the package here. It is not preinstalled. | |
168–169 | All the instructions in this section should be folded into the Arcanist setup sections for each OS above. | |
172 | Drop this section, and instead move the commands up into the respective OS-specific Arcanist setup instructions. | |
174 | Locate how? Remember, the reader won't necessarily know Linux. I know you address this in your comment, but many readers will just stop reading as soon as they don't understand something. Duplicate these instructions in the Linux, Alternative and macOS sections above. This won't work as-is for Windows (e.g. locate). You'll need to work out those instructions separately and add them to that section, or else just link to the readme on that morefas-phabricator repository. |
Got it, I will move the instructions to the appropriate places. Thanks for the correction.
Nice! Only a couple minor things now. Almost there!
source/tools/gitarc.rst | ||
---|---|---|
155 | I think this would follow a different highlighting. cmd maybe? If in doubt, feel free to use text instead. |