Change Onestring to onestring and update substr() info
ClosedPublic
Actions

Authored by galmonte on Mar 15 2021, 4:16 PM.

Details

Reviewers

jcmcdonald
ardunster

Commits

rONE87f4f6bf53b5: Change Onestring to onestring and update substr() info

Summary

Update the onestring docs to use onestring as the type is actually named in code, and clarify substr usage.

Test Plan

Diff Detail

Repository

rONE Onestring

Lint

Lint Not Applicable

Event Timeline

ardunster requested review of this revision.Mar 15 2021, 4:16 PM

ardunster created this revision.

Restricted Application completed remote builds in Restricted Buildable.Mar 15 2021, 4:16 PM

@galmonte This Differential has been awaiting merging for a while. I blame myself. Since you were just in the Onestring [Project] documentation, can you commandeer this revision, arc patch it, and rebase it against the latest devel (once you've merged your code?)

git checkout devel
git pull origin devel
arc patch D402
git rebase devel

You can use VSCode to handle the merge. I think I've walked you through this before? If not, let me know, and we can work together on it.

Herald added a project: Announce [Control]. · View Herald TranscriptAug 21 2021, 10:12 AM

Sure thing! I can work on that.

galmonte commandeered this revision.Aug 24 2021, 6:38 PM

galmonte added a reviewer: ardunster.

Rebased D402 up to date.

Restricted Application completed remote builds in Restricted Buildable.Aug 24 2021, 6:42 PM

Thank you!

One typo, and then this should be ready to land.

docs/source/onestring.rst
443–446

This revision now requires changes to proceed.Aug 28 2021, 10:57 AM

Fixed typo on line 443

Restricted Application completed remote builds in Restricted Buildable.Aug 31 2021, 5:19 PM

jcmcdonald accepted this revision.Oct 30 2021, 8:46 AM

This revision is now accepted and ready to land.Oct 30 2021, 8:46 AM

Closed by commit rONE87f4f6bf53b5: Change Onestring to onestring and update substr() info (authored by galmonte). · Explain WhyOct 30 2021, 9:59 AM

This revision was automatically updated to reflect the committed changes.

galmonte added a commit: rONE87f4f6bf53b5: Change Onestring to onestring and update substr() info.

Herald removed a project: Announce [Control]. · View Herald TranscriptOct 30 2021, 9:59 AM

Revision Contents
Changeset List

Path

Size

docs/

source/

onestring.rst

28 lines

Diff 2093

View Options

Change Onestring to onestring and update substr() infoClosedPublicActions