Page MenuHomePhabricator

Add std::bitset support in Stringify and Channel
ClosedPublic

Authored by jcmcdonald on Dec 9 2020, 3:06 PM.

Details

Summary
  • Add std::bitset support to stringify (Resolve T1411)
  • Stringify no longer ignores most IOFormat fields
Test Plan

Does it build and run, Jack?

Diff Detail

Repository
rI IOSqueak
Lint
Lint Not Applicable

Event Timeline

Restricted Application completed remote builds in Restricted Buildable.Dec 9 2020, 3:06 PM

Looks good! Builds fine on my end, quick question though: how would I make a feature request?

This revision is now accepted and ready to land.Dec 20 2020, 1:28 PM
In D367#12827, @memateo wrote:

Looks good! Builds fine on my end, quick question though: how would I make a feature request?

If you open Maniphest, then click to get the drop down where it lists "create task", one of the drop down options is a feature request form. Although that's the one you use for a project you're not working on. If you're working on the project as far as I know you just make a new task like normal (Jason can correct me if I'm wrong here).

If you open Maniphest, then click to get the drop down where it lists "create task", one of the drop down options is a feature request form. Although that's the one you use for a project you're not working on. If you're working on the project as far as I know you just make a new task like normal (Jason can correct me if I'm wrong here).

Thanks! And thanks once again for P59!

In D367#12832, @memateo wrote:

Thanks! And thanks once again for P59!

You're totally welcome! for both ;)