Page MenuHomePhabricator

Fix T1410
ClosedPublic

Authored by jcmcdonald on Nov 25 2020, 4:18 PM.

Details

Summary

Co-authored-by: Wilfrantz DEDE <contact@dede.dev>

We don't understand why there are two versions of many functions: const type& at() const and type& at(), for example.
std::vector::at() does the same thing. Why?

Test Plan

Build with make ready and confirm that it works in the use case in T1410.

Diff Detail

Repository
rP PawLIB
Lint
Lint Not Applicable

Event Timeline

Build is green

Building PawLIB on mpm-bionic-000crrkff8yv2 as build 559.
Running test suite P-sB13.

See https://jenkins.mousepawmedia.net:8449/job/pawlib_build/559/ for more details.

Build is green

Building PawLIB on mpm-bionic-000crsj47ouvp as build 560.
Running test suite P-sB12.

See https://jenkins.mousepawmedia.net:8449/job/pawlib_build/560/ for more details.

Build is green

Building PawLIB on mpm-bionic-000crt7asf51p as build 561.
Running test suite P-sB10.

See https://jenkins.mousepawmedia.net:8449/job/pawlib_build/561/ for more details.

Restricted Application completed remote builds in Restricted Buildable.Nov 25 2020, 4:21 PM

I'll see if I can check this quick after the meeting on Saturday (yeah, right.... ;) )

Simplex successfully compiles and passes all existing tests using FlexArray from this diff.

This revision is now accepted and ready to land.Nov 28 2020, 10:50 AM
This revision was automatically updated to reflect the committed changes.