Page MenuHomePhabricator
Differential D348

Matrix Transforms
Changes PlannedPublic
Actions

Authored by wdede on Oct 11 2020, 10:17 PM.

Details

Reviewers
mahussain
jcmcdonald
ardunster
memateo
Summary

Create class that transforms static layers using the MatrixTransform class

Test Plan

Create test classes

Diff Detail

Repository
rA Anari
Branch
MatrixTransforms
Lint
Lint Passed

Event Timeline

• gacmix created this revision.Oct 11 2020, 10:17 PM
Herald added projects: Anari [Project], IMF [Team], Programming [Dept]. · View Herald TranscriptOct 11 2020, 10:17 PM
• gacmix retitled this revision from Initial Commit to Matrix Transforms.Oct 11 2020, 10:18 PM
jenkins added a comment.Oct 11 2020, 10:18 PM

Build is green

Building Anari on mpm-bionic-0002v7qq1c4mn as build 237.

See https://jenkins.mousepawmedia.net:8449/job/anari_build/237/ for more details.

Restricted Application completed remote builds in Restricted Buildable.Oct 11 2020, 10:18 PM
• gacmix requested review of this revision.Oct 11 2020, 10:18 PM
• gacmix updated this revision to Diff 1609.Oct 11 2020, 10:26 PM
  • Update to MatrixTransform
jenkins added a comment.Oct 11 2020, 10:27 PM

Build is green

Building Anari on mpm-bionic-0002vei5ylk4j as build 238.

See https://jenkins.mousepawmedia.net:8449/job/anari_build/238/ for more details.

Restricted Application completed remote builds in Restricted Buildable.Oct 11 2020, 10:27 PM
• gacmix edited the summary of this revision. (Show Details)Oct 13 2020, 3:15 PM
• gacmix updated this revision to Diff 1611.Oct 13 2020, 3:44 PM
  • Pair programming work
jenkins added a comment.Oct 13 2020, 3:45 PM

Build has FAILED

Building Anari on mpm-bionic-0004c3ymh2h3m as build 239.

Link to build: https://jenkins.mousepawmedia.net:8449/job/anari_build/239/
See console output for more information: https://jenkins.mousepawmedia.net:8449/job/anari_build/239/console

Restricted Application failed remote builds in Restricted Buildable!Oct 13 2020, 3:45 PM
jcmcdonald requested changes to this revision.Oct 17 2020, 10:59 AM
jcmcdonald added inline comments.
anari-source/include/anari/matrix_transform.hpp
44–45

The linter is right about this. Here's how to initialize properly.

48–49

Same here...

53–54

I'll let you figure this one out accordingly. ;)

This revision now requires changes to proceed.Oct 17 2020, 10:59 AM
• gacmix updated this revision to Diff 1635.Oct 29 2020, 11:11 AM
• gacmix marked 3 inline comments as done.
  • Refactor transformation.hpp
  • Inital commit
• gacmix added a comment.Oct 29 2020, 11:11 AM

Resolved linting issues

• gacmix planned changes to this revision.Oct 29 2020, 11:12 AM
jenkins added a comment.Oct 29 2020, 11:12 AM

Build is green

Building Anari on mpm-bionic-000a9mm4tbtcp as build 242.

See https://jenkins.mousepawmedia.net:8449/job/anari_build/242/ for more details.

Restricted Application completed remote builds in Restricted Buildable.Oct 29 2020, 11:12 AM
• gacmix added reviewers: wdede, ardunster, memateo.Oct 29 2020, 11:41 AM
jcmcdonald added a comment.Nov 3 2020, 10:59 AM

@memateo You should Commandeer this revision. From the bottom of the page, go to Add Action... → Commandeer Revision. This will make you the author, and give you complete control over the diff, as if it were your own.

memateo commandeered this revision.Nov 3 2020, 2:31 PM
memateo edited reviewers, added: • gacmix; removed: memateo.
jcmcdonald removed a reviewer: • gacmix.Nov 3 2020, 2:31 PM
wdede commandeered this revision from memateo.Sep 1 2022, 6:44 AM
wdede edited reviewers, added: memateo; removed: wdede.
jcmcdonald mentioned this in D542: Rebase against Devel..Oct 15 2022, 10:52 AM

Revision Contents
Changeset List

PathSize
anari-source/
1 line
include/
anari/
6 lines
68 lines
7 lines
2 lines

Diff 1635

View Options

anari-source/CMakeLists.txt

Loading...
View Options

anari-source/include/anari/layerinstance.hpp

Loading...
View Options

anari-source/include/anari/matrix_transform.hpp

Loading...
View Options

anari-source/include/anari/transformation.hpp

Loading...
View Options

anari-source/include/anari/transformation_tests.hpp

Loading...
Copyright (C) 2019 MousePaw Media. All Rights Reserved. · Community Rules · Terms of Use · Privacy Policy · Terms of Development